add warning when using gradient_checkpointing with FSDP full shard #31578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yundai424
changed the title
yundai424
changed the title
SunMarc
approved these changes
Jun 25, 2024
There was a problem hiding this comment.
LGTM @yundai424 ! Thanks a lot for adding this ! cc @muellerzr
src/transformers/training_args.py
Outdated
| @@ -1794,6 +1794,13 @@ def __post_init__(self): | |||
| elif FSDPOption.FULL_SHARD in self.fsdp and FSDPOption.SHARD_GRAD_OP in self.fsdp: | |||
| raise ValueError("`--fsdp full_shard` is not compatible with `--fsdp shard_grad_op`.") | |||
|
|
|||
| if FSDPOption.FULL_SHARD in self.fsdp and self.gradient_checkpointing: | |||
There was a problem hiding this comment.
Is this only the case when we have FSDPOption.FULL_SHARD ?
There was a problem hiding this comment.
@SunMarc ah good point, hybrid shard also needs it. Update it now
amyeroberts
reviewed
Jun 25, 2024
Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>
Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
amyeroberts
approved these changes
Jul 5, 2024
There was a problem hiding this comment.
Thanks for adding!
@yundai424 Running make fixup should resolve the failing quality checks on the CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add a warning when using FSDP full shard with
gradient_checkpointingtraining arg to encourage users to use fsdp config'sactivation_checkpointinginstead.Fixes #30404
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@SunMarc @muellerzr